Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jtfell the charts all look good and the functions for the scatterplots seem ok. I'd just suggest maybe trying to align the tooltip when hovering to the right of the chart so not to overspill, but it's not too important, especially if we'll be displaying on pages with a right sidebar anyway.
Also I noticed the top and bottom dots are always right up the top and right down the bottom due to the extent clipping and they go above and below the axis labels. Again, maybe ask Ben if that's acceptable. We can kind of add margins by changing the .range values, but then it screws up the y axis line a bit.
Anyway It all seems pretty good, but yeah as I mentioned the errors (if any) will probably come out when testing different types of charts with the data.
Feel free to merge or just copy this change. It's pretty much just fixing a VS Code TypeScript error I was getting.
If anything major breaks down the track, I can give you a hand as I've got kinda my head around the code now.