Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variants selection option to JavaScript #1

Open
abdulhannanali opened this issue Feb 5, 2017 · 2 comments
Open

Add Variants selection option to JavaScript #1

abdulhannanali opened this issue Feb 5, 2017 · 2 comments
Assignees

Comments

@abdulhannanali
Copy link
Owner

We have the functionality to add a product, but right now, only the default product is added and there's no way to select a variant. This functionality can be added fairly simply by adding the select bar in the thumbnail and the ability for the user to select options.

@abdulhannanali abdulhannanali self-assigned this Feb 5, 2017
@abdulhannanali
Copy link
Owner Author

See #4 for another proposal, and the problem we have with selecting a variant, however this can be solved when we pass data at the top, and the product can be changed. Using a data structure such as Immutable.Map would be better instead of using the normal JavaScript object, as a lot of the manual work for deeply nested data will be done by it.

@abdulhannanali
Copy link
Owner Author

One other way can be to display each variant separately, while not optimal this can save us the hassle of managing more state related data as all the variants get their own thumbnail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant