Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues #1

Merged
merged 2 commits into from Sep 19, 2019

Conversation

@kirillDanshin
Copy link
Contributor

commented Sep 19, 2019

No description provided.

@kirillDanshin kirillDanshin referenced this pull request Sep 19, 2019
7 of 7 tasks complete
@codecov-io

This comment has been minimized.

Copy link

commented Sep 19, 2019

Codecov Report

Merging #1 into master will increase coverage by 0.07%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   94.26%   94.33%   +0.07%     
==========================================
  Files           7        7              
  Lines         157      159       +2     
==========================================
+ Hits          148      150       +2     
  Misses          6        6              
  Partials        3        3
Impacted Files Coverage Δ
here/enums.go 78.57% <80%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f111a21...11c9459. Read the comment docs.

@abdullahselek abdullahselek self-assigned this Sep 19, 2019
Copy link
Owner

left a comment

Added a single comment please have a look.

here/enums.go Outdated Show resolved Hide resolved
@abdullahselek abdullahselek merged commit 9bf8df5 into abdullahselek:master Sep 19, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 80% of diff hit (target 94.26%)
Details
codecov/project 94.33% (+0.07%) compared to f111a21
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.