Added support for SRV records, plus documentation and tests #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -225,6 +225,8 @@ func setupZoneData(data map[string]interface{}, Zone *Zone) { | |||
| "ns": dns.TypeNS, | |||
| "txt": dns.TypeTXT, | |||
| "spf": dns.TypeSPF, | |||
| "sshfp": dns.TypeSSHFP, | |||
There was a problem hiding this comment.
sshfp support, too? That should be a different pull request :-)
|
Got it, I've removed that sshfp line now. [ I'm maybe working on that next, maybe. I guess that's no longer a surprise. :) ] |
abh
added a commit
that referenced
this pull request
Jun 8, 2014
Added support for SRV records, plus documentation and tests
|
Very nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for SRV records, as well as basic tests and documentation. The result looks good on my dev instance:
$ dig _sip._tcp.test.example.com -t SRV @localhost
; <<>> DiG 9.9.2-P1 <<>> _sip._tcp.test.example.com -t SRV @localhost
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 50908
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0
;; WARNING: recursion requested but not available
;; QUESTION SECTION:
;_sip._tcp.test.example.com. IN SRV
;; ANSWER SECTION:
_sip._tcp.test.example.com. 600 IN SRV 10 100 5060 sipserver.example.com.
Note: I've used the variable srv_weight to distinguish between the weight that's internal to the SRV record struct vs. the "weight" that other records use. Let me know if this should be changed.