Fix compilation errors, API response handling, validation messages, a… #2
Conversation
…nd UI improvements - Fixed TypeScript compilation errors (signal types, unused imports, etc.) - Fixed API response mapping for answer submission (backend wraps response) - Fixed error message handling for date fields and validation constraints - Added refresh button to header with proper icon styling [] [] [] - Fixed duplicate question prevention in message list - Improved form control state management (disabled state handling) - Updated validator logic to apply min/max only for appropriate field types - Fixed Angular Signals context errors (runInInjectionContext) - Enhanced error messages with type-specific formatting - Improved UI styling for header, input bar, and message list - Fixed CORB issues in demo embedding - Updated TypeScript configuration and dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 12
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| canGoForward = computed(() => { | ||
| return this.allowForwardNav(); | ||
| return this.allowForwardNav; |
There was a problem hiding this comment.
Bug: Stale Computed Values from Non-Signal Inputs
The computed() function is being used with non-signal @input properties (allowBackNav, isFirstQuestion, allowForwardNav). Angular's computed() expects to read from signals to track dependencies and react to changes. Since these are plain boolean properties, the computed values will not update when the input properties change, causing the navigation buttons to have stale enabled/disabled states.
|
|
||
| // Restart session | ||
| this.startSession(); | ||
| } |
There was a problem hiding this comment.
Bug: Memory Leak: Refresh Fails to Unsubscribe Subscriptions
The refresh() method does not unsubscribe from existing subscriptions before calling startSession(). When refresh is called, it clears the session and messages, then starts a new session which adds new subscriptions to this.subscriptions. However, any in-flight HTTP requests from the previous session will continue and their subscriptions remain active, potentially causing memory leaks and unexpected behavior if they complete after the refresh. The method should call this.subscriptions.unsubscribe() and reinitialize this.subscriptions = new Subscription() before starting a new session.
abhattachar5
left a comment
abhattachar5
left a comment
There was a problem hiding this comment.
approved for merge
…nd UI improvements
Note
Stabilizes signals and form validation, adapts to wrapped API responses, adds refresh and UI/UX tweaks, and updates the demo/init config.
chat-widget-shell):expand(); wraps effects inrunInInjectionContextand fixes signal usages; prevents duplicate questions; restart flow viarefresh(); wiring fixes for inputs/controls.input-bar):isLoadingto boolean; improves placeholders/ARIA; converts submit to labeled button; enables/disables via form control; per-type min/max validators; clearer error messages; format example helper.disabledis boolean and tooltip position adjusted.api: supportapiBaseUrl; map wrappedsubmitAnswerresponse; retry/backoff cleanup; typing fixes.session: update sessionprogressfrom envelopes; refine clear/set flows.analytics: relaxed payload typing; remove unnecessary casts.accessibility: minor focus handler cleanups.WidgetConfig: optionalapiBaseUrl.QuestionEnvelope:questionnullable, optionalsessionId, addprogress,decision,decisionReason.InsuranceChatWidgetModule.initoversetConfig, demo JWT,apiBaseUrl); TS config includes*.ts.typescriptto~5.4.0.Written by Cursor Bugbot for commit 5d09222. This will update automatically on new commits. Configure here.