Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack exhuasted #3

Closed
Triangleowl opened this issue Dec 23, 2019 · 2 comments
Closed

Stack exhuasted #3

Triangleowl opened this issue Dec 23, 2019 · 2 comments

Comments

@Triangleowl
Copy link

hi, I only modified the input image file and cause stack exhausted. I think variable buffer should not be defined as a local variable, but should be dynamically applied for heap space. :)
crash.zip

@abhijitnathwani
Copy link
Owner

Hi @Triangleowl ,
I tried opening the crash.bmp file which you've uploaded. I cannot open the file. My system stopped responding. Can you check if it is correct file? Then, i can check.
And yes, we could assign the memory dynamically. I'll add that when time permits. Feel free to raise a PR if you wish.

@Triangleowl
Copy link
Author

hi abhijitnathwani,
Sorry, I can open the crash.bmp in my Windows 10 use WPS viewer, but can't open other
Picture viewer. Because I adjusted the 18th to 25th bytes of the crash.bmp file, which will be assigned to width and height. This can lead to stack exhaustion or integer overflow.
I think you should do some checks to prevent integer overflow or stack exhausted.
Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants