From 5f7066a8657f73466c23618d063d3a45fcb2e2f7 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Thu, 20 Jan 2022 11:28:52 +0530 Subject: [PATCH 1/2] Fix devtools build --- Makefile | 4 ++-- dashboard/src/core/devtools.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 35f35b888c..51f12a4412 100644 --- a/Makefile +++ b/Makefile @@ -176,10 +176,10 @@ lib-pyreverse: open pyreverse.png devtools: - pushd dashboard && npm run devtools && popd + pushd dashboard && npm install && npm run devtools && popd dashboard: - pushd dashboard && npm run build && popd + pushd dashboard && npm install && npm run build && popd dashboard-clean: if [[ -d dashboard/public ]]; then rm -rf dashboard/public; fi diff --git a/dashboard/src/core/devtools.ts b/dashboard/src/core/devtools.ts index 77fc789451..fe933f9ab7 100644 --- a/dashboard/src/core/devtools.ts +++ b/dashboard/src/core/devtools.ts @@ -31,7 +31,7 @@ function setUpDevTools () { } const chromeDevTools = path.dirname( - require.resolve('chrome-devtools-frontend/front_end/inspector.json') + require.resolve('chrome-devtools-frontend/front_end/visibility.gni') ) console.log('Destination folder: ' + destinationFolderPath) From a6c02ad3981bb376384bc2b721002a3aa4de435f Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Thu, 20 Jan 2022 11:30:53 +0530 Subject: [PATCH 2/2] Build devtools as part of GHA workflows --- .github/workflows/test-library.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/test-library.yml b/.github/workflows/test-library.yml index 785df5a80c..ef6f014860 100644 --- a/.github/workflows/test-library.yml +++ b/.github/workflows/test-library.yml @@ -703,6 +703,11 @@ jobs: cd dashboard npm run build cd .. + - name: Build Devtools + run: | + cd dashboard + npm run devtools + cd .. developer: runs-on: ${{ matrix.os }}-latest