Support --hostnames - #1325
Conversation
1a4613b to
f5e3add
Compare
461a979 to
8341ea0
Compare
psf-chronographer
Bot
added
the
bot:chronographer:provided
8341ea0 to
cb7921f
Compare
abhinavsingh
left a comment
abhinavsingh
left a comment
There was a problem hiding this comment.
LGTM. PTAL at my comment related to windows & its workflow.
Thank you
bc78ffc to
0942dba
Compare
4d58af2 to
467cb2e
Compare
|
@abhinavsingh your turn to tame your CI :) |
|
I restarted the failed jobs. Due to certain integration tests, which uses upstream httpbin.org and pythonhosted.org, we end up receiving server side / rate limiting errors. As a result, these tests can fail sometimes. Usually, restarting them always makes them work. |
|
@alexey-pelykh So workflow went fine after restarting failed jobs. Docker and GHCR are related to secrets and permissions for PRs I suppose. I'll take another stab at it sometime tonight or morrow and merge it. Thank you for adding this capability. It certainly can be used to scale proxy.py even further on a single host machine. |
|
@abhinavsingh how's it going on your end? any changes needed? |
Hi @alexey-pelykh , apologies, I got derailed a release work past/this week. Promise, I'll take a look again and merge this weekend. Thank you. |
|
@alexey-pelykh LGTM, made few minor edits directly in the PR. Workflow revealed failures which led me to home-assistant/core#91283 🤦♂️ Damn. Will need to fix the |
2 participants
No description provided.