Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@flavio-fernandes
Copy link

flavio-fernandes commented Mar 6, 2016

  • add obj directory, so build does not fail
  • add log directory, so log open does not fail
  • remove unneeded exit calls, so code path finishes naturally upon sigint
  • replaced commented out code in worker.c with #ifdef DEBUG
  • remove duplicate SUFFIXES line in Makefile
  • remove log/pulsar.log on make clean
  • cast void* into pointer type before doing assignment from allocators
  • use const char* for log_new() and _logger struct
  • fix conf_free(conf *cfg) signature in header file

flavio-fernandes added some commits Mar 6, 2016

Minor fixes
- add obj directory, so build does not fail
- add log directory, so log open does not fail
- remove uneeded exit calls, so code path finishes naturally upon sigint
- replaced commented out code in worker.c with #ifdef DEBUG
- remove duplicate SUFFIXES line in makefile
- remove log/pulsar.log on make clean
Minor fixes
- cast void* into pointer type before doing assignment from allocators
- use const char* for log_new() and _logger struct
- fix conf_free(conf *cfg) signature in header file
Do not attempt to log if fd is -1 as well as NULL
In logic that determies if log should take place or not (log_it)
there is a check for accounting for cases when file descriptor
is NULL. It should also check if fd is -1, which is a potential
value returned by open().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.