-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why are the websockets closing with status 1006? #7
Comments
|
I've gone so far as to replace the aiohttp servers with sanic, but this doesn't seem to fix the problem. My intuition was that perhaps the aiohttp websocket implementation was broken. Alas. We'll need to add logic to the web client and runner_repl to deal with this, I suppose. |
|
This is still happening, and I still don't know why, but our implementation seems to be robust against it now. I'm going to leave this open for now, but I'm not going to put any time into right now. |
|
It could be this: https://stackoverflow.com/questions/28828332/gorilla-websocket-disconnects-after-a-minute I ran some experiments to see if I could replicate these disconnects, and I wasn't able to. The experiment did not, however, include nginx, so perhaps we can configure nginx to stop killing the websocket proxies. |
|
Some quick timing certainly seems to support the hypothesis that nginx is timing websocket proxies out after 1 minute. |
|
I've verified to my satisfaction that nginx timeouts are the problem. In the default configuration, the I'm going to consider the mystery solved, though we still need to figure out how to handle timeouts gracefully. For now I'm going to set the timeouts to 10 hours. |
The browser is showing that our websockets to runner_repl are closing with status 1006, and I can't figure out why. This happens after 10 or 20 seconds if inactivity, it seems, though I'm not sure if there's a real relationship.
This happens across browsers: chrome, firefox, and safari at least.
The text was updated successfully, but these errors were encountered: