Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercise tic-tac-toe #2

Merged
merged 7 commits into from Mar 6, 2019

Conversation

Projects
None yet
7 participants
@paulotijero
Copy link
Collaborator

paulotijero commented Mar 4, 2019

Nos falta el empate tecnico

Show resolved Hide resolved week-1/the-pokes/tictactoe.rb Outdated
end

end

This comment has been minimized.

Copy link
@DiegoCuevas

DiegoCuevas Mar 4, 2019

Collaborator

un mensaje diciendo que no se puede reingresar en un casillero ya tomado

This comment has been minimized.

Copy link
@paulotijero

paulotijero Mar 4, 2019

Author Collaborator

Nice advice!!

Show resolved Hide resolved week-1/the-pokes/tictactoe.rb


# pos_human : Es el valor que ingresa el usuario
pos_human = turnHuman(notPlayed(value_human+value_bot))

This comment has been minimized.

Copy link
@sergiodxa

sergiodxa Mar 4, 2019

Member

I like how you composed those functions to create a result 👍

Show resolved Hide resolved week-1/the-pokes/tictactoe.rb Outdated
Show resolved Hide resolved week-1/the-pokes/tictactoe.rb Outdated

def notPlayed(value)
arrNP = TABLE - value
return arrNP

This comment has been minimized.

Copy link
@KattyaCuevas

KattyaCuevas Mar 4, 2019

Collaborator

No es necesario crear una variable y usar el método return


def turnBot(value)
if(value != [])
value.sample

This comment has been minimized.

Copy link
@KattyaCuevas

KattyaCuevas Mar 4, 2019

Collaborator

Se puede poner en una sola línea

@KattyaCuevas KattyaCuevas merged commit f3f2a93 into ableco:master Mar 6, 2019

KattyaCuevas pushed a commit that referenced this pull request Mar 12, 2019

KattyaCuevas pushed a commit that referenced this pull request Mar 12, 2019

condef5 pushed a commit that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.