Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap each line of captions within its own <div> #224

Open
terrill opened this issue May 20, 2016 · 0 comments
Open

Wrap each line of captions within its own <div> #224

terrill opened this issue May 20, 2016 · 0 comments

Comments

@terrill
Copy link
Member

terrill commented May 20, 2016

Currently caption text is wrapped in this.$captionWrapper, which can include multiple lines of caption text. Wrapping each line in its own container would serve two purposes:

  1. The inline-block for each line would only need to be as a wide as the text for that line (rather than one large block). This would result in less obstructive text when displayed as an overlay.
  2. Will be one step closer to supporting roll-up captions (Add support for caption styles: pop-on vs roll-up #15) and WebVTT positioning (Add full support for WebVTT  #13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant