Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change names of client type values from presence data #136

Closed
KacperKluka opened this issue Apr 22, 2021 · 0 comments · Fixed by #137
Closed

Change names of client type values from presence data #136

KacperKluka opened this issue Apr 22, 2021 · 0 comments · Fixed by #137
Assignees
@QuintinWillison
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@KacperKluka
Copy link
Contributor

KacperKluka commented Apr 22, 2021 •
edited by ably-sync-bot

We've overlooked one place when we were applying our naming convention for enum values ably/ably-asset-tracking-android#207.

The client types sent in the PresenceData are currently written in lowercase "subscriber", "publisher". We should change it to "SUBSCRIBER", "PUBLISHER".

We should be extra careful with this change as it will break the compatibility with older SDK versions as well as other platforms (the other platforms will start working as soon as they make this change on their sides too).

┆Issue is synchronized with this Jira Task by Unito
┆Issue Number: ATS-361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuintinWillison QuintinWillison

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conform JSON representation of presence message client type values ably/ably-asset-tracking-swift
2 participants
@QuintinWillison @KacperKluka