Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle resolutions for the location engine in the Publisher #248

Merged
merged 3 commits into from Jan 31, 2022
Merged

Handle resolutions for the location engine in the Publisher #248

merged 3 commits into from Jan 31, 2022

Conversation

lukasz-szyszkowski
Copy link
Contributor

No description provided.

@lukasz-szyszkowski lukasz-szyszkowski linked an issue Jan 25, 2022 that may be closed by this pull request
Handle resolutions for the location engine in the Publisher #113
Closed
KacperKluka
KacperKluka suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@KacperKluka KacperKluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it's missing something 😉

Sources/AblyAssetTrackingPublisher/Services/DefaultLocationService.swift Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/248/jazzy January 25, 2022 12:53 Inactive
KacperKluka
KacperKluka approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@KacperKluka KacperKluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maratal maratal self-requested a review January 28, 2022 16:38
@lukasz-szyszkowski lukasz-szyszkowski merged commit 7c547cd into main Jan 31, 2022
@lukasz-szyszkowski lukasz-szyszkowski deleted the feature/113-handle-resolutions-for-the-location- branch January 31, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maratal maratal maratal approved these changes

@KacperKluka KacperKluka KacperKluka approved these changes

@AndyNicks AndyNicks AndyNicks approved these changes

@lawrence-forooghian lawrence-forooghian Awaiting requested review from lawrence-forooghian

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle resolutions for the location engine in the Publisher
4 participants
@lukasz-szyszkowski @maratal @KacperKluka @AndyNicks