Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1305 symmetric decryption #1307

Merged
merged 13 commits into from Apr 10, 2022
Merged

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Mar 14, 2022

Partially closes ably/docs#1305

  1. I've only added decryption for ARTMessage, because of absence of encrypted test data for ARTPresenceMessage. I could use the same file but I'm not sure, lets discuss.
  2. fromEncodedJsonArray omits error while iterating and calling decodeWithEncoder for each item, because in the original code (from ARTRestChannel.history) this error goes nowhere except logger. And in this static function I have no logger, except one I can directly pass into fromEncodedJsonArray, but that would be in contradiction with spec requirement for this function signature (TM3).

Source/ARTMessage.h Outdated Show resolved Hide resolved
Source/ARTMessage.m Outdated Show resolved Hide resolved
Source/ARTMessage.h Outdated Show resolved Hide resolved
Source/ARTMessage.m Outdated Show resolved Hide resolved
@lawrence-forooghian
Copy link
Collaborator

@maratal, I don't think we can say "Closes #1305" if we're not handling PresenceMessage here. We should either handle it here or split that issue in two.

Source/ARTMessage.h Outdated Show resolved Hide resolved
Source/ARTMessage.m Outdated Show resolved Hide resolved
Source/ARTMessage.m Outdated Show resolved Hide resolved
Source/ARTMessage.m Outdated Show resolved Hide resolved
@maratal
Copy link
Collaborator Author

maratal commented Mar 25, 2022

I don't think we can say "Closes ably/docs#1305" if we're not handling PresenceMessage here. We should either handle it here or split that issue in two.

Since there is no reliable way to detect which type of message in the provided dictionary, I have nothing to do except add similar methods to ARTPresenceMessage class. I'll do it once we agree upon all changes for ARTMessage. @lawrence-forooghian

@maratal
Copy link
Collaborator Author

maratal commented Apr 1, 2022

Since there is no reliable way to detect which type of message in the provided dictionary, I have nothing to do except add similar methods to ARTPresenceMessage class. I'll do it once we agree upon all changes for ARTMessage.

I agree to create one more PR to actually fully address corresponding issue (I'll reopen it after this PR merged).

@maratal maratal merged commit c89c67b into main Apr 10, 2022
@maratal maratal deleted the feature/1305-symmetric-decryption branch April 10, 2022 12:13
@QuintinWillison QuintinWillison added enhancement New feature or improved functionality. spec-alignment labels Jul 20, 2022
maratal pushed a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants