Handle errors in Request() #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the tests may actually be failing for real here. Need to look into it. |
My interpretation of RSC19e is that Request() should only return an error if there's a network error. However it also states the standard fallback rulles apply. So we save the response then check it's status. If the status we return an error so that the fallback functions trigger. If we end up with an error still after exausting all fallbacks then we return the last req that succeeded. This lets us try fallbacks and also return bad requests for the user to inspect.
Morganamilo
force-pushed
the
uncheckedstatus
branch
from
f1700bd
to
73ab707
Compare
The code only falls back when the status code is 500 but gives up right away if the request failed outright.
Rosalita
approved these changes
Apr 13, 2022
mohyour
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errors like 500 response codes are not checked and don't
return an error.
Request is still broken but may as well push this fix as I've moved to other stuff for the time being.