JSON encoding exception - handle encoding failures

[mattheworiordan]

See log below:

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x2bf6849f __exceptionPreprocess
1  libobjc.A.dylib                0x39722c8b objc_exception_throw
2  CoreFoundation                 0x2bf683e5 -[NSException initWithCoder:]
3  Foundation                     0x2ccdadc1 _writeJSONValue
4  Foundation                     0x2ccdc953 ___writeJSONObject_block_invoke
5  CoreFoundation                 0x2be863ed __65-[__NSDictionaryM enumerateKeysAndObjectsWithOptions:usingBlock:]_block_invoke
6  CoreFoundation                 0x2be8630f -[__NSDictionaryM enumerateKeysAndObjectsWithOptions:usingBlock:]
7  Foundation                     0x2ccdc5d3 _writeJSONObject
8  Foundation                     0x2ccdacff _writeJSONValue
9  Foundation                     0x2ccdab15 -[_NSJSONWriter dataWithRootObject:options:error:]
10 Foundation                     0x2ccdb9af +[NSJSONSerialization dataWithJSONObject:options:error:]
11 Acme                           0x3b3923 -[ARTJsonEncoder encode:] (ARTJsonEncoder.m:31)
12 Acme                           0x3b7e45 -[ARTJsonLikeEncoder encode:] (ARTJsonLikeEncoder.m:708)
13 Acme                           0x3b3cc7 -[ARTJsonLikeEncoder encodeProtocolMessage:] (ARTJsonLikeEncoder.m:122)
14 Acme                           0x3d0a0b -[ARTWebSocketTransport send:] (ARTWebSocketTransport.m:73)
15 Acme                           0x3bec57 -[ARTRealtime sendImpl:callback:] (ARTRealtime.m:595)
16 Acme                           0x3becd3 -[ARTRealtime send:callback:] (ARTRealtime.m:600)
17 Acme                           0x3c1e9b -[ARTRealtimeChannel sendMessage:callback:] (ARTRealtimeChannel.m:222)
18 Acme                           0x3c183b -[ARTRealtimeChannel publishProtocolMessage:callback:] (ARTRealtimeChannel.m:187)
19 Acme                           0x3c0f0b -[ARTRealtimeChannel internalPostMessages:callback:] (ARTRealtimeChannel.m:86)
20 Acme                           0x3aaee3 -[ARTChannel publish:data:callback:] (ARTChannel.m:48)
21 Acme                           0x36aaad -[AcmeAblyController publishToChannel:topicName:data:] (AcmeAblyController.m:114)
22 Acme                           0x36cb5b -[AcmeEventPublisher publishAnalyticsEventWithDTO:] (AcmeEventPublisher.m:33)
23 Acme                           0x36df19 __59-[AcmeAnalyticsEventDispatch dispatchAnalyticsEventWithDTO:]_block_invoke (AcmeAnalyticsEventDispatch.m:78)
24 libdispatch.dylib              0x39c827a7 _dispatch_client_callout
25 libdispatch.dylib              0x39c89ac9 _dispatch_barrier_sync_f_invoke
26 Acme                           0x36ddff -[AcmeAnalyticsEventDispatch dispatchAnalyticsEventWithDTO:] (AcmeAnalyticsEventDispatch.m:75)
27 Acme                           0x129da3 +[AcmeventTracker trackAnalyticsEventWithDTO:] (AcmeventTracker.m:1182)
28 Acme                           0x1873db -[AcmetemDetailViewController trackItemViewedEvent] (AcmetemDetailViewController.m:813)
29 Acme                           0x1822b9 __57-[AcmetemDetailViewController addOfferProxySuccessHandler]_block_invoke_2 (AcmetemDetailViewController.m:243)
30 libdispatch.dylib              0x39c827bb _dispatch_call_block_and_release
31 libdispatch.dylib              0x39c827a7 _dispatch_client_callout
32 libdispatch.dylib              0x39c85fa3 _dispatch_main_queue_callback_4CF
33 CoreFoundation                 0x2bf2e3b1 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
34 CoreFoundation                 0x2bf2cab1 __CFRunLoopRun
35 CoreFoundation                 0x2be7a3c1 CFRunLoopRunSpecific
36 CoreFoundation                 0x2be7a1d3 CFRunLoopRunInMode
37 GraphicsServices               0x332780a9 GSEventRunModal
38 UIKit                          0x2f4887b1 UIApplicationMain
39 Acme                           0xfaf85 main (main.m:18)
40 libdyld.dylib                  0x39ca2aaf start

We should be:

• Using https://developer.apple.com/reference/foundation/nsjsonserialization/1418461-isvalidjsonobject?language=objc to check an object is valid to be encoded
• Ensure nil values are handled
• Handle these encoding issues gracefully and callback with an error

[ricardopereira]

@tcard I'm looking at this.

[ricardopereira]

“Ably (0.8.12) successfully published” https://github.com/ably/ably-ios/releases/tag/0.8.12
“Ably (1.0.2) successfully published” https://github.com/ably/ably-ios/releases/tag/1.0.2