Test suites: reuse test app. #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this, we isolate tests by prepending a prefix to channel names in different tests (ie. that use different calls to TestUtilties.setupOptions.) This should make #397 unnecessary.
|
|
||
| if debug { | ||
| options.logLevel = .Verbose | ||
| print(response) | ||
| print(testApplication!) |
There was a problem hiding this comment.
Ups, nevermind. Didn't saw the debug.
There was a problem hiding this comment.
Well, it is printing exactly the same as it was doing before. Note the if debug {.
|
LGTM 😃 perfect... tests in 10min! |
|
Now that is what I like, a 3x saving in time! |
tcard
added a commit
that referenced
this pull request
May 16, 2016
For this, we isolate tests by prepending a prefix to channel names in different tests (ie. that use different calls to TestUtilties.setupOptions.) This should make #397 unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this, we isolate tests by prepending a prefix to channel names in
different tests (ie. that use different calls to
TestUtilties.setupOptions.)
This should make #397 unnecessary.