New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge push into develop #761

Merged
merged 99 commits into from Aug 9, 2018

Conversation

3 participants
@funkyboy
Copy link
Collaborator

funkyboy commented Aug 8, 2018

No description provided.

ricardopereira and others added some commits Feb 7, 2017

Initial Push types
ARTPushNotifications interface

Realtime: integrate Push type

Rest: integrate Push type

Push.activate

Push.publish

 - add PushRecipient protocol

PushChannel subscribe and unsubscribe

Fix registerCallback

Remove warnings

 - unused methods

Fix FormFactor

Fix: use device token as Hex string

Fix: should respect the default encoder

 - useBinaryProtocol

Remove ARTPushRecipient protocol and types

Add ULID pod

Use ULID as DeviceId

Push.deactivate

Load local device

Push: update device

PushChannel.subscriptions

Update ULID pod

PushAdmin

Update ULID pod

Remove warnings

JSON encoder: normalize deviceToken hex string

Fix: Push.publish request body

Update device forms

Activation State Machine: init

Activation State Machine: registration

Removed ablyPushAuthKey, ablyPushAuthToken and ablyPushClientId from push delegate

Add Rest argument on Push delegate

Fix things for push, and adapt to latest API.

Push: add registering delegate methods for Realtime too.

Add new private headers to modulemap.

Fix rebase merge conflicts.

Recalculate Podfile.lock checksum.
ARTPushActivationState: use init instead of new.
With a static method, the constructed class is always the parent
abstract class ARTPushActivationState, instead of the desired child
class.

Fixes #628.
Push Admin tests (#642)
* MockHTTPExecutor

* PushAdmin

* Move `publish` method to Admin

* Add `get` method in PushDeviceRegistrations

* Should use response encoder type

* Fix save channel subscription

* Fix save device registration

* Better errors information

* Rename publish notification argument to data to conform specs

* Add equatable to DeviceDetails

* Fix DeviceRegistrations.get

* Add validations to PushAdmin.publish

* Fix RHS1a

* Fix RHS1b1

* Fix PushAdmin implementation

* Fix ambiguous reference to member 'dataTask(with:completionHandler:)'

* fixup! Fix PushAdmin implementation

* CI test

* fixup! Fix PushAdmin implementation
Push ActivationStateMachine tests (#662)
* Initial Push types

* Update project

* ARTPushNotifications interface

* Realtime: integrate Push type

* Rest: integrate Push type

* Push.activate

* fixup! Push.activate

* Push.publish

 - add PushRecipient protocol

* fixup! Push.publish

* PushChannel subscribe and unsubscribe

* Fix registerCallback

* Remove warnings

 - unused methods

* Fix FormFactor

* Fix: use device token as Hex string

* Fix: should respect the default encoder

 - useBinaryProtocol

* Remove ARTPushRecipient protocol and types

* Add ULID pod

* Use ULID as DeviceId

* Push.deactivate

* Load local device

* Push: update device

* PushChannel.subscriptions

* Update ULID pod

* PushAdmin

* Update ULID pod

* Remove warnings

* JSON encoder: normalize deviceToken hex string

* Fix: Push.publish request body

* Update device forms

* Activation State Machine: init

* Activation State Machine: registration

* Removed ablyPushAuthKey, ablyPushAuthToken and ablyPushClientId from push delegate

* Add Rest argument on Push delegate

* tmp

* Fix things for push, and adapt to latest API.

* Initial State Machine tests

* ARTLocalDeviceStorage

* Fix: ARTPushActivationState

* Storage should synchronize UserDefaults

* Storage Keys accessible on tests

* State Machine tests

* ActivationStateMachine: custom delegate and other fixes

* PushActivationStateMachine

* Implement Device storage

* Fix headers

* Fix tests
Implement Device IdentityToken
 - it replaces the Device UpdateToken
Fix: LocalDevice shouldn't stick with the Rest instance
 - LocalDevice is shared in different Rest instances because of the
dispatch_once. The initial Rest instance could be released and the
LocalDevice would be using an invalid Rest object.

@funkyboy funkyboy requested review from ricardopereira and paddybyers Aug 8, 2018

@funkyboy funkyboy merged commit b66cfe6 into develop Aug 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@funkyboy funkyboy deleted the push branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment