Skip to content

Add bevy_reflect support#17

Merged
abnormalbrain merged 3 commits intoabnormalbrain:mainfrom
johanhelsing:bevy_reflect
Nov 23, 2022
Merged

Add bevy_reflect support#17
abnormalbrain merged 3 commits intoabnormalbrain:mainfrom
johanhelsing:bevy_reflect

Conversation

@johanhelsing
Copy link
Contributor

@johanhelsing johanhelsing commented Nov 16, 2022

This makes it possible for tools like bevy-inspector-egui to show an editor for ParticleSystems.

Added it as a default feature so it can be disabled if not needed.

image

This makes it possible for tools like bevy-inspector-egui to show an
editor for `ParticleSystem`s.

Added it as a default feature so it can be disabled if not needed.
Copy link
Collaborator

@theanti9 theanti9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be good to add a section about the feature in the README.md as well.

@johanhelsing
Copy link
Contributor Author

It would probably be good to add a section about the feature in the README.md as well.

Actually, I think it may be better to just unconditionally derive Reflect. See: StarArawn/bevy_ecs_tilemap#298 (comment)

@abnormalbrain abnormalbrain added the enhancement New feature or request label Nov 23, 2022
@abnormalbrain abnormalbrain merged commit a48d35c into abnormalbrain:main Nov 23, 2022
@johanhelsing johanhelsing deleted the bevy_reflect branch November 23, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants