PR #24 breaks building project with makefile in `helm-make-buildir' or "build" #24

Closed
cslux opened this Issue Nov 9, 2016 · 3 comments

Projects

None yet

2 participants

@cslux
Contributor
cslux commented Nov 9, 2016 edited

Solution:
Append "build" or value of `helm-make-buildir' to the -C option of make.

regards,
Christian

@abo-abo
Owner
abo-abo commented Nov 9, 2016

I don't understand what you mean. You have a fix?

@cslux
Contributor
cslux commented Nov 9, 2016

What I mean is: In helm--make the variable default-directory will be set to the path where the makefile is located. This can be the project root directory or projcet root + build or project root + helm-make-build-dir, so make gets called in that directory, but after #24 make always switches to projectile-project-root. The argument to the make -C option should be the same as the variable default-directory in helm--make will be set.

I'll create a PR.

@cslux cslux closed this Nov 9, 2016
@cslux cslux reopened this Nov 9, 2016
@cslux cslux added a commit to cslux/helm-make that referenced this issue Nov 9, 2016
@cslux cslux Fix bug introduced in #24
We need to set the argument of the make option `-C` to the path the
Makefile is located in.
1174434
@cslux
Contributor
cslux commented Nov 9, 2016

@lszekeres Why not call recompile?

@abo-abo abo-abo closed this Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment