Improve lispy--bounds-list #420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move backward when after a closing delimiter (previously only moved forward when at an opening delimiter); use lispy-left and lispy-right for checking
Contributor
Author
|
I removed the comment exiting behavior since it is useless as |
Owner
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
lispy--bounds-listwill exit strings but not comments. I like that it returns the same bounds when at the opening delimiter (e.g. so that(goto-char (car (lispy--bounds-list)))will not move to earlier delimiters with repeated calls) but would like if this behavior was also mirrored for closing delimiters. I don't know if the current behavior is intentional, but all tests pass for me with these changes.