Incorrect window-start with ivy-avy #1004
Comments
Thanks for catching this. Please test. |
Thank you for tending to this. I do not, however, think the problem is completely fixed. Although the correct candidate is selected now, the string returned by Adjusting my previous steps to reproduce:
|
Reopening. PRs welcome. |
I'd like to investigate further but I don't expect to make much progress over the next month or two (I also need to submit a copyright assignment). |
No problem, take your time. |
hi, not sure if this behavior observed is related to this issue:
C-' (ivy-avy) works as expected on commands like Counsel-M-x though and also works as expected on command 'find-file' C-xC-f. |
I'm seeing the same behaviour as @suryaaditya although it doesn't appear to work anywhere for me. For example, with |
@suryaaditya Your example works fine on my system. Please try to reproduce with |
@abo-abo I've taken up your suggestion and can reproduce the issue with the following setting:
|
@ryankask Thanks. It's easy to fix once it's reproducible. |
I'm having this issue with Emacs 26.1 on macOS mojave.
Weird because I had no issues before but now start to have some. (use-package avy
:ensure t
:bind ("M-s" . avy-goto-word-1))
(use-package counsel
:ensure t
:config
(counsel-mode))
(use-package ivy
:ensure t
:bind (("C-c C-r" . ivy-resume)
:map ivy-minibuffer-map
("C-'" . ivy-avy))
:config
(ivy-mode 1)
(setq ivy-use-virtual-buffers t)
(setq ivy-count-format "%d/%d ")
(setq ivy-display-style 'fancy))
(use-package swiper
:ensure t
:after (ivy avy)
:bind ("C-s" . swiper))
(use-package ivy-rich
:ensure t
:after ivy
:init
(setq ivy-rich-path-style 'abbrev
ivy-virtual-abbreviate 'full)
:config (ivy-rich-mode 1))
;; Actions
;;;;;;;;;;;;;;;
;;; delete files when perusing your file system
;; (ivy-set-actions
;; 'counsel-find-file
;; '(("d" delete-file "delete")))
(defun dired-mode-setup ()
"Hook for dired-mode."
(dired-hide-details-mode 1))
(add-hook 'dired-mode-hook 'dired-mode-setup)
;; allow dired to delete or copy dir
(setq dired-recursive-copies (quote always)) ; “always” means no asking
(setq dired-recursive-deletes (quote top)) ; “top” means ask once
(setq dired-dwim-target t) |
Steps to reproduce
emacs -Q
M-x package-initialize RET
M-x ivy-mode RET
M-: (ivy-read "Pick a number: " (mapcar #'number-to-string (number-sequence 0 (ash ivy-height 1)))) RET
M->
C-'
a
"12"
"0"
I believe I have narrowed the problem down to function
window-start
always returning1
, even when scrolled further down the candidate list. What I find peculiar is thatwindow-end
is always correct and(pos-visible-in-window-p (window-start)
is alwayst
. I have tried callingredisplay
and callingwindow-end
as(window-end nil t)
before callingwindow-start
but the result is always the same.The text was updated successfully, but these errors were encountered: