Incorrect window-start with ivy-avy

[basil-conto]

Steps to reproduce

1. emacs -Q
2. M-x package-initialize RET
3. M-x ivy-mode RET
4. M-: (ivy-read "Pick a number: " (mapcar #'number-to-string (number-sequence 0 (ash ivy-height 1)))) RET
5. M->
6. C-'
7. Select candidate a
8. • Expected result: "12"
   • Actual result: "0"

I believe I have narrowed the problem down to function window-start always returning 1, even when scrolled further down the candidate list. What I find peculiar is that window-end is always correct and (pos-visible-in-window-p (window-start) is always t. I have tried calling redisplay and calling window-end as (window-end nil t) before calling window-start but the result is always the same.

[abo-abo]

Thanks for catching this. Please test.

[basil-conto]

Thank you for tending to this. I do not, however, think the problem is completely fixed. Although the correct candidate is selected now, the string returned by ivy-read includes the surrounding formatting context.

Adjusting my previous steps to reproduce:

1. emacs -Q
2. M-x package-initialize RET
3. M-x ivy-mode RET
4. M-: (setq ivy-format-function #'ivy-format-function-arrow) RET
5. M-: (ivy-read "Pick a number: " (mapcar #'number-to-string (number-sequence 0 (ash ivy-height 1)))) RET
6. M->
7. C-'
8. Select candidate a
9. • Expected result: "12"
   • Actual result: " 12"

[abo-abo]

Reopening. PRs welcome.

[basil-conto]

I'd like to investigate further but I don't expect to make much progress over the next month or two (I also need to submit a copyright assignment).

[abo-abo]

No problem, take your time.

[suryaaditya]

hi, not sure if this behavior observed is related to this issue:
Steps:

1. counsel-find-file
2. C-'(ivy-avy)
3. instead of the opening the file selected, it tries to open a brand new buffer.

C-' (ivy-avy) works as expected on commands like Counsel-M-x though and also works as expected on command 'find-file' C-xC-f.

[ryankask]

I'm seeing the same behaviour as @suryaaditya although it doesn't appear to work anywhere for me. For example, with counsel-M-x I see apply: Wrong type argument: commandp, \ \ apropos.

[abo-abo]

@suryaaditya Your example works fine on my system. Please try to reproduce with emacs -Q (or use make plain from this repo).

[ryankask]

@abo-abo I've taken up your suggestion and can reproduce the issue with the following setting:

(setq ivy-format-function 'ivy-format-function-arrow)

[abo-abo]

@ryankask Thanks. It's easy to fix once it's reproducible.