Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Preselected value gets added to candidates #1017
The problem with the action can probably be circumvented by adding an additional check whether the input is part of the collection, so no big deal there. But still I think it looks off to have an entry in the list which is completely different than the others., e.g. a regexp among a list of symbols.
I would appreciate if somebody could explain the use cases of this feature to me. Thank you.
referenced this issue
May 25, 2017
This does break
When there is no input, then the latter returns the default even if it is not a member of the completion candidates. However, it does not actually add the default to the list of candidates and therefore won't display it when pressing
So I think it is unintentional that for
Magit will have to be adjusted regardless of what you decide, since here the intention is for the default to be treated as a completion candidate (for all completion frameworks, including the default one).
Since this is being done, I'll keep the current behavior in Ivy, since I think it's simpler. I think the weird behavior of