Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on pressing TAB #1024

Closed
drot opened this issue May 21, 2017 · 12 comments
Closed

Error on pressing TAB #1024

drot opened this issue May 21, 2017 · 12 comments

Comments

@drot
Copy link

@drot drot commented May 21, 2017

Started occuring after the last commits:
region

@skylerlee
Copy link

@skylerlee skylerlee commented May 21, 2017

Yes, I have the same problem. Also, I can't use <right> key to select alternatives using counsel-find-file.

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented May 21, 2017

It's working fine here.

Could you try to replicate the error with emacs -Q? See here, if you don't know how to do it.

@drot
Copy link
Author

@drot drot commented May 21, 2017

The issue still persists with emacs -Q and enabling ivy-mode.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 21, 2017

What are the steps to reach the screenshot. I clearly see there's a problem, but I have no idea how you got there, everything works fine on my system.

@drot
Copy link
Author

@drot drot commented May 21, 2017

  1. Start with emacs -Q
  2. M-x package-initialize
  3. M-x ivy-mode
  4. C-x C-f
  5. Complete .emacs.d with first TAB, after pressing TAB the second time to enter the directory the error above happens. C-j for example works normally.
@unmanbearpig
Copy link

@unmanbearpig unmanbearpig commented May 21, 2017

I've got the same error in Emacs built from master via homebrew --HEAD on latest macOS.
It happens when I hit tab in find-file with a completed directory name. It seems to work fine in all other cases.

  1. I type in a directory name or something that can be completed to a directory name
  2. Hit tab and it completes the name with a / at the end
  3. Hit tab again and expect to get a list of files in that directory, but instead get that error.

Here is a video https://youtu.be/I8rEwM-9gsY

I was running it with emacs -Q -nw, package-initialize and ivy-mode.
Let me know if I can help debugging it somehow.

@rakanalh
Copy link

@rakanalh rakanalh commented May 21, 2017

I am seeing the same issue running the latest MELPA version:

ivy                20170519.824  dependency 
counsel            20170518.1425 dependency  

On mac osx using Emacs 25.2.1.

Question: Previously, a single tab used to also work but now to tab strokes are required to select the completion... was the old behavior changed?

@abo-abo abo-abo closed this in ec71273 May 21, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 21, 2017

Thanks all, should be fixed now.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 21, 2017

Question: Previously, a single tab used to also work but now to tab strokes are required to select the completion... was the old behavior changed?

Please try to git bisect and find the commit when TAB changed. I never use TAB, so I wouldn't know.

@rakanalh
Copy link

@rakanalh rakanalh commented May 22, 2017

@abo-abo out of curiosity, when you highlight the directory you need, what do YOU use to have ivy go into it and display files inside that directory?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 22, 2017

@rakanalh C-j will do this.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 22, 2017

I also have this binding in my config:

(define-key ivy-minibuffer-map (kbd "<return>") 'ivy-alt-done)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.