Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab: ivy-partial-or-done #1027

Closed
rakanalh opened this Issue May 22, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@rakanalh
Copy link

rakanalh commented May 22, 2017

Hi,

It seems to me that there was an issue introduced in recent versions of Ivy where hitting "TAB" would invoke ivy-partial-or-done which automatically and implicitly did what ivy-alt-done was doing if the candidate you hit TAB on was the only matching one.

So in case you try to find-file and type .emacs.d, given that there's no other file/dir that match these names hitting tab after typing .emacs would perform ivy-alt-done rather than requiring two tabs.

Thank you

@abo-abo abo-abo closed this in 07212d9 May 22, 2017

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented May 22, 2017

Thanks.

@rakanalh

This comment has been minimized.

Copy link
Author

rakanalh commented May 22, 2017

Thank you for resolving this in such a timely manner! much appreciated

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented May 22, 2017

You're welcome.

@rakanalh

This comment has been minimized.

Copy link
Author

rakanalh commented May 22, 2017

So it was just upgradable through MELPA and i gave it a go.
Say i have a directory called
~/Code
So when i perform C-x C-f, starting ~, i type 'code' then TAB, ivy doesn't advanced into the Code directory but rather shows the minibuffer as follows:

Find file: code/[cursor here]
./
../

Although the directory isn't empty.

I experimented with this a bit and found that pressing TAB on the only candidate directory is similar to pressing / so it just takes my input as is and not considering that what i want is to navigate into selected candidate.

@Lenbok

This comment has been minimized.

Copy link

Lenbok commented May 22, 2017

I only see 2017-0515.1409 in melpa, which predates the fix for this issue, so perhaps melpa just hasn't built the new one (I don't know how often it rebuilds).

@rakanalh

This comment has been minimized.

Copy link
Author

rakanalh commented May 22, 2017

I have

ivy-20170522.913

Maybe you should package-refresh-contents?

@Lenbok

This comment has been minimized.

Copy link

Lenbok commented May 22, 2017

My bad - I assumed that since we were in abo-abo/swiper repo, that I should be looking at the swiper package in melpa, but ivy melpa package is where we expect to see the fix.

@Lenbok

This comment has been minimized.

Copy link

Lenbok commented May 22, 2017

I have updated to ivy-20170522.913 and can confirm that the problem you describe in #1027 (comment) still exists, so it seems this is not fixed.

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented May 23, 2017

@rakanalh Please open a new issue with some description of the directory structure and the steps.

@drot

This comment has been minimized.

Copy link

drot commented May 23, 2017

Works fine here, I made a video. Created the Code directory and some other directories inside. As seen on the video typing code and pressing TAB after that descends into the directory.

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented May 23, 2017

@drot Works fine for me too, but maybe it doesn't with some specific directory names of @rakanalh

@rakanalh

This comment has been minimized.

Copy link
Author

rakanalh commented May 23, 2017

Here's the follow up bug
#1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.