Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-partial has become overeager in case folding #1036

Closed
xendk opened this issue May 27, 2017 · 8 comments
Closed

ivy-partial has become overeager in case folding #1036

xendk opened this issue May 27, 2017 · 8 comments

Comments

@xendk
Copy link

@xendk xendk commented May 27, 2017

ivy-partial folds pretty much everything to lowercase whenever it completes now, regardless of the presence of capital letters, rendering completion pretty useless with case sensitive data.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 28, 2017

Example please.

@xendk
Copy link
Author

@xendk xendk commented May 29, 2017

Say that I have a /tmp/UpperCase file. Using counsel-find-file I have /tmp/Up in the minibuffer, and press tab, it changes it to /tmp/uppercase. Which works because it still selects the candidate, but if there's also an uppercase file, it gets annoying as that'll suddenly be the default.

@xendk
Copy link
Author

@xendk xendk commented Jun 1, 2017

And it absolutely kills the ivy-read on something case sensitive I'm trying to do.

@xendk xendk changed the title ivy-partia has become overeager in case folding ivy-partial has become overeager in case folding Jun 1, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 1, 2017

What are your settings? Can you provide an example like this:

(ivy-read "test: " '("one" "uppercase"))
@xendk
Copy link
Author

@xendk xendk commented Jun 2, 2017

Qute simple:

(ivy-read
 "test: "
 '("case" "Case"))

Typing Ca and tab completes to case.

@cmm
Copy link

@cmm cmm commented Jun 12, 2017

Not a real problem for me yet (no files that differ only by case), but definitely an eyesore.

@abo-abo abo-abo closed this in 30e8b83 Jun 12, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 12, 2017

Thanks, please test.

@xendk
Copy link
Author

@xendk xendk commented Jun 13, 2017

👍 Excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants