New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point in minibuffer after counsel-find-file when using ivy-partial-or-done #1051

Closed
justbur opened this Issue Jun 5, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@justbur
Contributor

justbur commented Jun 5, 2017

This seems pretty weird, since it's so basic, but it's been annoying me and I can't figure out what's happening. It also doesn't happen all the time and mostly seems related to the screen splitting.

Steps:

  1. emacs -Q
  2. M-x package-initialize
  3. M-x ivy-mode
  4. M-x counsel-mode
  5. M-x counsel-find-file [some read only file like /etc/ssh/ssh_config]

Result:

You can't really see it, but point is in the minibuffer here.

minibuffer

@justbur

This comment has been minimized.

Contributor

justbur commented Jun 5, 2017

By the way, I couldn't reproduce if I initialize the packages (steps 1-2) and just use the built-in find file.

@justbur justbur changed the title from Point in minibuffer after counsel-find-file on read only file to Point in minibuffer after counsel-find-file when using ivy-partial-or-done Jun 6, 2017

@justbur

This comment has been minimized.

Contributor

justbur commented Jun 6, 2017

ok, I narrowed down the problem.

  1. M-x counsel-find-file
  2. /etc TAB
  3. Select a file

Before the TAB (ivy--get-window ivy-last) is correct. After TAB it's set to the minibuffer. It get's reset through the call to minibuffer-complete in ivy-partial-or-done, which calls ivy-completion-in-region. It looks like this is the offending line, but I don't know why it's there, so I'm not going to touch it.

justbur added a commit to justbur/swiper that referenced this issue Jun 6, 2017

Avoid setting ivy window as minibuffer
* ivy.el (ivy-completion-in-region): Don't set ivy window to minibuffer window

Fixes abo-abo#1051

@abo-abo abo-abo closed this in #1053 Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment