Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy interferes with `sql-connect` command #1112

Closed
glucas opened this issue Jul 18, 2017 · 1 comment
Closed

Ivy interferes with `sql-connect` command #1112

glucas opened this issue Jul 18, 2017 · 1 comment

Comments

@glucas
Copy link
Contributor

@glucas glucas commented Jul 18, 2017

At some point a change in ivy introduced a problem when trying to use the sql-connect command. The problem has been reported on Emacs StackExchange: the completion cannot find a match regardless of the available set of connections and the input text.

This was working fine in the past, but I don't recall when I first saw the problem appear.

Think I can boil the test case down to this:

(completing-read "Connection: " '("test") nil t nil nil '(nil) nil)

When I have ivy-mode on, this call won't let me complete 'test'. If I turn off ivy-mode, completion of 'test' works. It seems like the issue may be the DEF argument -- replacing that with nil works.

@abo-abo abo-abo closed this in e35dae3 Jul 18, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 18, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.