Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch buffer arrows wont work if a pattern is entered #1159

Closed
1bharat opened this issue Aug 14, 2017 · 21 comments
Closed

Switch buffer arrows wont work if a pattern is entered #1159

1bharat opened this issue Aug 14, 2017 · 21 comments

Comments

@1bharat
Copy link

@1bharat 1bharat commented Aug 14, 2017

While switching to buffer in ivy, if no pattern is entered, arrows (ctrl j/k) work perfectly. When a pattern is entered, arrows (ctrl j/k) stops working.

This behaviour does not occur with searching(swiper), dired. Only happens with switching buffer.

This started today. I searched for an existing issue for this but i didnt find any or didnt understand if they were the same. Let me know if there is a bug already for this.

package -
ivy-20170813.351

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 14, 2017

Can you reproduce with emacs -Q?

@dieggsy
Copy link
Contributor

@dieggsy dieggsy commented Aug 14, 2017

Huh, I'm actually experiencing this too, though I haven't been able to reproduce with emacs -Q yet

@Stebalien
Copy link
Contributor

@Stebalien Stebalien commented Aug 14, 2017

Same here on spacemacs. I'll try to reproduce with a minimal setup when I have time.

@1bharat
Copy link
Author

@1bharat 1bharat commented Aug 14, 2017

I am using spacemacs as well. I was not able to reproduce with emacs -Q

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 15, 2017

@jbharat Then next step after emacs -Q is emacs -Q -l init.el; you put only your ivy-specific config in init.el.

@1bharat
Copy link
Author

@1bharat 1bharat commented Aug 15, 2017

@abo-abo I tested it with stock emacs. Buffer switch works fine(with/without pattern) in ivy. Seems to be an issue with spacemacs. Should I close this?

@dieggsy
Copy link
Contributor

@dieggsy dieggsy commented Aug 15, 2017

@jbharat I am not using spacemacs, so it may be an issue with evil...

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 15, 2017

Should I close this?

Let's wait until someone posts a reproducible scenario. The issue affects many people.

@Dickby
Copy link

@Dickby Dickby commented Aug 16, 2017

I have this problem too, it seems to be triggered by setting ivy-regex-builder-alist to ivy-regex-ignore-order (probably related to #1163)

@1bharat
Copy link
Author

@1bharat 1bharat commented Aug 16, 2017

@Dickby I have tested by removing all additional config of ivy. I have just ivy layer added to my .spacemacs file. I am still facing this issue. I dont know which package is causing this.

@abo-abo abo-abo closed this in aa3c9c6 Aug 16, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 16, 2017

@Dickby thanks for the pointer, please test.

@dieggsy
Copy link
Contributor

@dieggsy dieggsy commented Aug 16, 2017

@abo-abo i think that fixed some of it, though I think if I enter text for which there is an exact match (but also other matches) I still can't move the arrow keys.

e.g. (| marks cursor)

Switch-to-buffer: thing|
  thing1
  thing2
  thing

The selection will remain at thing without being able to move unless I either type less than the exact match, or add a space.

abo-abo added a commit that referenced this issue Aug 16, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 16, 2017

@dieggsy thanks for the pointer, please test.

@1bharat
Copy link
Author

@1bharat 1bharat commented Aug 16, 2017

working for me. Thanks @abo-abo @dieggsy

@zzjjzzgggg
Copy link

@zzjjzzgggg zzjjzzgggg commented Aug 17, 2017

When I search a string containing white space, e.g., "aaa bbb", ivy just matches "aaa", and doesn't match "bbb".

@1bharat
Copy link
Author

@1bharat 1bharat commented Aug 17, 2017

@zzjjzzgggg if you are using fuzzy, just use aaabbb. I think it will match it.

@zzjjzzgggg
Copy link

@zzjjzzgggg zzjjzzgggg commented Aug 17, 2017

@jbharat I am not using fuzzy. Searches containing white spaces no longer work after the recent two commits. 6290e0a, aa3c9c6

@dieggsy
Copy link
Contributor

@dieggsy dieggsy commented Aug 17, 2017

@abo-abo your commit seemed to point out the latest issue I pointed out, however I can now confirm @zzjjzzgggg 's described behavior as well (that is, anything after a space now does nothing to further narrow candidates.)

@1bharat
Copy link
Author

@1bharat 1bharat commented Aug 17, 2017

Yep pattern after space is ignored. Tested

abo-abo added a commit that referenced this issue Aug 17, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 17, 2017

Please try again.

For minibuffer highlights when using swiper, add e.g.

(add-to-list 'ivy-highlight-functions-alist
             '(swiper--re-builder . ivy--highlight-ignore-order))
@Dickby
Copy link

@Dickby Dickby commented Aug 17, 2017

looks good! fixes #1163 aswell.

mrnugget added a commit to mrnugget/emacs.d that referenced this issue Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants