ivy-use-selectable-prompt doesn't work when a dynamic collection is empty #1183

Activity

1. fabacino commented on Oct 31, 2017

   

   fabacino

   on Oct 31, 2017

   Contributor

   More actions

   Could reproduce the issue with

   (ivy-read "choose: "
             '(lambda (x)
                (if (> (length x) 2)
                    '()
                  '("a" "b" "c")))
             :dynamic-collection t)

   I will take a look at it.
2. fabacino

   added a commit that references this issue on Oct 31, 2017

   ivy.el (ivy--exhibit): Update prompt even if there are no candidates

   ...

   This issue will close once commit 55d1898 is merged into the 'master' branch.

   55d1898
3. abo-abo

   closed this as completedin #1265on Oct 31, 2017
4. abo-abo

   reopened this on Nov 1, 2017
5. abo-abo commented on Nov 1, 2017

   

   abo-abo

   on Nov 1, 2017

   Owner

   More actions

   @fabacino Sorry, I have to revert your commit: it breaks the smooth redisplay for :dynamic-collection. The minibuffer is blinking rapidly as the user types. We'll have to figure out how to fix this.
6. abo-abo

   added a commit that references this issue on Nov 1, 2017

   Revert "ivy.el (ivy--exhibit): Update prompt even if there are no can…

   ...

   9c8f4a4
7. fabacino

   added a commit that references this issue on Nov 2, 2017

   ivy.el (ivy--exhibit): Update prompt even if there are no candidates

   ...

   This issue will close once commit b7f2700 is merged into the 'master' branch.

   b7f2700
8. fabacino commented on Nov 2, 2017

   

   fabacino

   on Nov 2, 2017

   Contributor

   More actions

   @abo-abo Thanks for your feedback. I think the problem is that a value of nil for ivy--all-candidates can mean two different things:

   1. The function (sync or async) has returned no candidates.
   2. We don't know the candidates yet, because an async function is still running.

   I made a new fix, basically checking if there is a running counsel process. If there is, an async function is still running and we don't refresh the minibuffer. If there is none, however, we can safely assume that the function has returned an empty set of candidates. In that case, we update the minibuffer.

   fabacino@b7f2700

   If you like it, I can PR. The hard-coded process name is not pretty, but there are other references to the counsel package within ivy.el, so I figured it is probably ok.
9. abo-abo commented on Nov 2, 2017

   

   abo-abo

   on Nov 2, 2017

   Owner

   More actions

   If you like it, I can PR. The hard-coded process name is not pretty, but there are other references to the counsel package within ivy.el, so I figured it is probably ok.

   Sounds good, please PR. We can refactor the hard-coded stuff later if there's a need.
10. abo-abo

    closed this as completedin #1270on Nov 3, 2017