You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On a computer where I don´t have git installed, every time I try to use M-p from counsel-find-file (which runs ivy-previous-history-element) I get an error message that says 'Required program "git" not found in your path'.
The reason this message occurs is that counsel adds counsel-emacs-url-p and counsel-github-url-p to the variable ivy-ffap-url-functions which is used by ivy--cd-maybe. Those functions use counsel-require-program to check that git is installed and produce an error message if it is not.
Is this really the best way to handle this? I'd prefer to have counsel-emacs-url-p and counsel-github-url-p just silently return nil if the use doesn't have git, rather than see an error message every time I try to use the history in counsel-find-file. Or maybe have counsel check for git before putting counsel-emacs-url-p and counsel-github-url-p in ivy-ffap-url-functions. The point is a gitless person should just not get the extra functionality instead of being constantly scolded. :P
The text was updated successfully, but these errors were encountered:
oantolin
changed the title
If you don't have git installed and have counsel-find-file-at-point set to t, using M-p from counsel-find-file raises a user-error
If you don't have git installed, using M-p from counsel-find-file raises a user-error
Sep 27, 2017
On a computer where I don´t have git installed, every time I try to use
M-p
fromcounsel-find-file
(which runsivy-previous-history-element
) I get an error message that says 'Required program "git" not found in your path'.The reason this message occurs is that
counsel
addscounsel-emacs-url-p
andcounsel-github-url-p
to the variableivy-ffap-url-functions
which is used byivy--cd-maybe
. Those functions usecounsel-require-program
to check that git is installed and produce an error message if it is not.Is this really the best way to handle this? I'd prefer to have
counsel-emacs-url-p
andcounsel-github-url-p
just silently returnnil
if the use doesn't have git, rather than see an error message every time I try to use the history incounsel-find-file
. Or maybe havecounsel
check for git before puttingcounsel-emacs-url-p
andcounsel-github-url-p
inivy-ffap-url-functions
. The point is a gitless person should just not get the extra functionality instead of being constantly scolded. :PThe text was updated successfully, but these errors were encountered: