Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-rg no longer works #1236

Closed
jeberger opened this issue Oct 11, 2017 · 7 comments
Closed

counsel-rg no longer works #1236

jeberger opened this issue Oct 11, 2017 · 7 comments

Comments

@jeberger
Copy link
Contributor

@jeberger jeberger commented Oct 11, 2017

Since c9f86b5, counsel-rg does nothing.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2017

Can't reproduce. The commit you cite looks harmless.

@jeberger
Copy link
Contributor Author

@jeberger jeberger commented Oct 11, 2017

I just double-checked with emacs -Q. It works with the default settings, but it stops working at that commit when I enable ivy-auto-select-single-candidate.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2017

Pinging @fabacino, author of ivy-auto-select-single-candidate.

@abo-abo abo-abo closed this in f7470fe Oct 11, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2017

@jeberger Thanks, the change is now reverted for dynamic collections.

@jeberger
Copy link
Contributor Author

@jeberger jeberger commented Oct 11, 2017

Thanks for your reactivity

@fabacino
Copy link
Contributor

@fabacino fabacino commented Oct 26, 2017

I was on vacation a couple of weeks and did not see the ping until now. Sorry about that.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 26, 2017

@fabacino No problem:), welcome back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants