Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-avy broken with ivy-set-display-transformer #1255

Closed
tmdmelo opened this Issue Oct 29, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@tmdmelo
Copy link
Contributor

tmdmelo commented Oct 29, 2017

  • Observed behavior:

Selecting a candidate with ivy-avy uses the text returned by the display transformer function.

  • Expected behavior:

ivy-avy uses the candidate text without changes by the display transformer function.

For example, with the following:

(defun my-display-transformer (text)
  (concat text "-foobar"))

(ivy-set-display-transformer 'ivy-switch-buffer 'my-display-transformer)

Then trying to switch to buffer <BUFFER-NAME> using ivy-avy switches to a buffer <BUFFER-NAME>-foobar instead.

Switching to a buffer without using ivy-avy works as expected.

I'll send a PR with a proposed fix.

tmdmelo added a commit to tmdmelo/swiper that referenced this issue Oct 29, 2017

ivy.el (ivy-avy): Selects correct candidate
When using a display transformer.

Fixes abo-abo#1255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.