Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
counsel-fzf feedback #1263
Thanks for incorporating fzf into counsel. It's nice to have the same/consistent UI with other counsel functions in using fzf. I was really glad to see PR #1151 recently go through.
After using counsel-fzf for a day or two, I couldn't help notice that it behaved slightly different than counsel-recentf.
The latter progressively displays the letters that one is typing, where for counsel-fzf the letters being typed are not highlighted?
Below are two screenshots to highlight the difference.
counsel-recentf highlights "ihb" of other possible selections, whereas for counsel-fzf it doesn't highlight the "sgpgmelp" I typed in.
How can this consistency be ironed out so that counsel-fzf behaves and looks like other counsel functions like counsel-recentf?
I realized "sgpgmelp" was a very narrow a item to search, searching for "sgpgmd" is a broader search.
Attached is a second screenshot of that broader search -- and still the same UI experience, no highlighting of characters that matched.
The visual cues of what letters were typed in as in counsel-recentf is very helpful, and it would be awesome if it too were shown in counsel-fzf.
Is it using flx?
I'm still wondering how the progressive pattern matching is done for counsel-recentf and not being done for counsel-fzf. Thanks @jojojames .