-
-
Notifications
You must be signed in to change notification settings - Fork 339
counsel-fzf feedback #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I realized "sgpgmelp" was a very narrow a item to search, searching for "sgpgmd" is a broader search. Attached is a second screenshot of that broader search -- and still the same UI experience, no highlighting of characters that matched. The visual cues of what letters were typed in as in counsel-recentf is very helpful, and it would be awesome if it too were shown in counsel-fzf. |
Hmnn, I don't think it's possible. counsel-recentf probably matches and highlights the matches using flx or something. fzf under the hood is just using fzf -f to get a list back. |
Is it using flx? https://github.com/abo-abo/swiper/blob/master/counsel.el#L1783 ;;;###autoload I'm still wondering how the progressive pattern matching is done for counsel-recentf and not being done for counsel-fzf. Thanks @jojojames . |
@agsdot @jojojames Thanks, please test. |
@agsdot I'm pretty sure counsel-recentf is just using the pattern matching through its own matcher. Fzf has its own pattern matching so you won't be able to get highlighting out of it. |
Much better. Thanks @abo-abo. |
@jojojames. So far so good. Haven't used/tested it too much though. The most important thing is/was the accuracy of the fzf results. Secondary is the highlight -- it's just a nice convenience. Thanks @abo-abo and @jojojames for working on this. |
Can we see only the git files some way? I did ask this in #1525. I think it is a matter of changing in the input command. Anyone knows if this is configurable or a way to change that? |
@varmanishant You can use setenv. (setenv "FZF_DEFAULT_COMMAND" |
@jojojames and @abo-abo,
Thanks for incorporating fzf into counsel. It's nice to have the same/consistent UI with other counsel functions in using fzf. I was really glad to see PR #1151 recently go through.
After using counsel-fzf for a day or two, I couldn't help notice that it behaved slightly different than counsel-recentf.
The latter progressively displays the letters that one is typing, where for counsel-fzf the letters being typed are not highlighted?
Below are two screenshots to highlight the difference.
counsel-recentf highlights "ihb" of other possible selections, whereas for counsel-fzf it doesn't highlight the "sgpgmelp" I typed in.
How can this consistency be ironed out so that counsel-fzf behaves and looks like other counsel functions like counsel-recentf?
Thanks!
The text was updated successfully, but these errors were encountered: