Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Don't restore location on C-g #1319

Closed
jwiegley opened this issue Nov 24, 2017 · 3 comments

Comments

@jwiegley
Copy link

commented Nov 24, 2017

I'm finding that sometimes, I want to be where I end up, even if the start begins to fail. C-g takes me back to the beginning of the search, so it requires me to look at my search string, and "correct" it until it becomes a successful match for the present location so that I can press RET and stay there.

I'd like both:

  • an option that allows C-g to stay wherever the cursor ends up, successful or not

  • a keybinding for "abort and stay", whose behavior is flipped with "abort" if the above is set

@manuel-uberti

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2017

FWIW, I like the second option more.

@abo-abo abo-abo closed this in c101525 Dec 6, 2017

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 6, 2017

Thanks.

a keybinding for "abort and stay", whose behavior is flipped with "abort" if the above is set

Would be nice, but there are little to none good key bindings left. Especially considering that one of Ivy's key guidelines is that the minibuffer should still behave as a proper editable text field (i.e. don't touch C-f etc).

I've added a boolean toggle instead, off by default. Even when it's on, you can get the old C-g either with C-k C-g or C-k RET, since the starting line is preselected, and when there's no input Ivy returns back to the preselected candidate.

@manuel-uberti

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

Superb, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.