Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicates in counsel-minibuffer-history? #1358

Closed
danielmatz opened this issue Dec 8, 2017 · 1 comment

Comments

@danielmatz
Copy link

commented Dec 8, 2017

The new counsel-minibuffer-history variable was a great addition, thank you.

After using it for a while now, I think that it would be nice to have it copy the history variable and delete duplicates. If, for example, I run the same shell command a lot, when I use counsel-minibuffer-history all of the visible matching completions can be the same command, which seems like a waste of space.

I'm aware of history-delete-duplicates, but that would change the contents of the history variable itself. Perhaps a user would like the duplicates in the history, so that, for example, stepping backwards through shell commands would retain all the commands that were run. But then when filtering the candidates with counsel, the ordering is no longer relevant, and removing duplicates would be more useful.

@danielmatz danielmatz changed the title Delete duplicates in counsel-minibuffer-history Delete duplicates in counsel-minibuffer-history? Dec 8, 2017

@abo-abo abo-abo closed this in 5f50cb3 Dec 8, 2017

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 8, 2017

Thanks, please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.