Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiper history broken #1391

Closed
xendk opened this issue Jan 2, 2018 · 5 comments
Closed

Swiper history broken #1391

xendk opened this issue Jan 2, 2018 · 5 comments

Comments

@xendk
Copy link

@xendk xendk commented Jan 2, 2018

The history in swiper seems to forget all but the last entry. swiper-history seems fine, contains all history items, and other ivy commands like counsel-find-files history works just without problem.

I've reproduced the error on c2bc6ac in a clean Emacs with nothing else loaded.

Pressing M-p selects the last history item, but subsequent M-p doesn't change the item. However, an equal number of M-n needs to be pressed to reach an empty line again.

@abo-abo abo-abo closed this in 27c900a Jan 2, 2018
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 2, 2018

Thanks.

@xendk
Copy link
Author

@xendk xendk commented Jan 2, 2018

Sorry, but it's still a bit odd. I have to press M-p twice to get the previous element most of the time?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 2, 2018

Thanks again, please check.

@xendk
Copy link
Author

@xendk xendk commented Jan 2, 2018

👍
Typing M-n at the end the history seems to pick up the word at point, but I think that's a feature? Apart from that it behaves as expected.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 2, 2018

Typing M-n at the end the history seems to pick up the word at point, but I think that's a feature?

Yes.

Apart from that it behaves as expected.

Thanks for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants