counsel-find-file-at-point does not respect ffap-url-regexp

[raxod502]

Starting from emacs -Q, I load revision f7470fe of counsel.el, set counsel-find-file-at-point to non-nil and set ffap-url-regexp to nil. According to the documentation string of ffap-url-regexp,

Regexp matching the beginning of a URI, for ffap.
If the value is nil, disable URL-matching features in ffap.

this should disable URL-matching features of ffap. And it does, if I run M-x ffap with point at | as shown:

https://google.com|

But if I instead run counsel-find-file, Emacs attempts to ping google.com. This indicates to me that the setting of ffap-url-regexp is not being respected by counsel-find-file.

[abo-abo]

counsel-find-file wasn't designed to conform to ffap-url-regexp, it uses ivy-ffap-url-functions instead.

I'm open to a PR on this, if it isn't difficult. But the current interface should be good enough for customization purposes.

[raxod502]

That makes sense. But I think ivy-ffap-url-functions is unrelated; setting it to nil does not change the behavior above. I investigated, and it actually happens because of the following clause in counsel-find-file:

            :preselect (when counsel-find-file-at-point
                         (require 'ffap)
                         (let ((f (ffap-guesser)))
                           (when f (expand-file-name f))))

(ffap-guesser) returns /https:/google.com, and expand-file-name on that gives /scp:https:/google.com, so Emacs invokes scp and tries/fails to open a connection.

On re-checking my example above, I found that the same happens for M-x ffap, but I didn't notice originally since it doesn't happen until you actually press RET to find the file, rather than immediately as in counsel-find-file.

[abo-abo]

Thanks, please test.

But I think ivy-ffap-url-functions is unrelated

You're right. I mentioned it because that's how I always open URLs (with C-x C-f M-n). I keep counsel-find-file-at-point the default nil value, that's why I never encountered the buggy behavior.

[raxod502]

The behavior remains the same (i.e. Emacs invokes scp when I type C-x C-f). Maybe it is outside the realm of counsel.el, though?

In any case, I should probably switch to using ivy-ffap-url-functions instead of counsel-find-file-at-point—the former seems more powerful and better designed.