counsel-git-grep sometimes searches for any text without a prompt

[ryankask]

Sometimes when running counsel-git-grep, the command appears to search for any text without first prompting:

I would normally expect to see this prompt:

I see screenshot one when I run the command for the first time after creating a new buffer or switching to an existing one. Subsequent calls prompt as in the second screenshot. It's not always the case though but I haven't noticed a pattern.

[abo-abo]

I can't do much without a reproduction scenario.

That said, the idea is:

• if the repo line count is below 20k lines, pipe all lines into Emacs and use Elisp filtering, which is pretty fast in that case.
• otherwise, let git-grep do the filtering for each input and send the results to Emacs.

It seems you're getting case 1, even though your repo line count is above 20k lines.

Try evaling (counsel--gg-count "" t) to see if the result ever gets messed up.

[ryankask]

Thanks for the tip. I used emacs -Q -l ... and saw it happening as well.

Running (counsel--gg-count "" t) after switching to the buffer returns 6269 at first. Then, after running consel-git-grep aain, (counsel--gg-count "" t) evaluates to 113081.

[abo-abo]

This is the shell command that runs in counsel--gg-count:

git --no-pager grep -c -n --no-color -i -e "" | sed 's/.*:\(.*\)/\1/g' | awk '{s+=$1} END {print s}'

Can you check what it returns for you?

[ryankask]

I see that the lower count is the result of the above command running in the buffer's default-directory. The higher count is the result of running the command from the root of the repository.

I forgot to mention that I recently upgraded to emacs 26.0.90 so this could be causing problems.

[abo-abo]

Thanks, please check if it's fixed for you.

[ryankask]

Thanks for your work on this. It didn't seem to solve the issue. counsel--gg-count assigns default-directory to (ivy-state-directory ivy-last) and it's this value that changes between the parent directory of the buffer's file and the git repository root path.

[ryankask]

@abo-abo Would it be possible to reopen this issue?

[abo-abo]

OK. Please provide a minimal repro if you can. I wasn't sure I fixed it last time.

[ryankask]

Here is a way to reproduce the issue:

1. Clone a larger git repository git clone https://github.com/facebook/react.git
2. Run make plain
3. Open $REPO_DIR/react/packages/react/index.js
4. Run counsel-git-grep
5. Screenshot shows the result for me

[dfrib]

+1 for also seeing this issue, sporadically, in a repo with <= 20 000 lines, using Emacs 25.3. Possible a regression as I've only ever run into it after my latest cask packages wipe/reinstall. Currently using swiper-20180101.1035.

Setting counsel-git-grep-skip-counting-lines to non-nil (as show by @ryankask in his linked commit) seems to fix it, though.

(use-package counsel
  :after ...
  :bind (...
         ("C-c j" . 'counsel-git-grep)
         ...)
  :init (setq counsel-git-grep-skip-counting-lines t)
  )

... if the repo line count is below 20k lines, pipe all lines into Emacs and use Elisp filtering, which is pretty fast in that case.

For this case (which should be present for my repo) it would seems as if (counsel-more-chars 3) in counsel.el does not take precedence in case counsel-git-grep-skip-counting-lines is nil, as directly upon invocation of counsel-git-grep a huge list is dumped in the minibuffer. Maybe (split-string (shell-command-to-string cmd) "\n" t) is a participating culprit; overwriting the light-weight fake candidates from counsel-more-chars with a (non-lazy?) large list of sub-strings?

[ideasman42]

Running into this problem recently too.

Why is (counsel--gg-count "" t) needed? - it's taking a long time on 4,090,614 lines of code in our project.
As well as showing part of the results in the output (which is the bug).

This fails quite often too with an error:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  find-file-name-handler(nil process-file)
  process-file("/bin/zsh" nil t nil "-c" "git --no-pager grep -c -n --no-color -e \"\" -- 'CMakeLists.txt' '*.cmake' | sed 's/.*:\\(.*\\)/\\1/g' | awk '{s+=$1} END {print s}'")
  shell-command-to-string("git --no-pager grep -c -n --no-color -e \"\" -- 'CMakeLists.txt' '*.cmake' | sed 's/.*:\\(.*\\)/\\1/g' | awk '{s+=$1} END {print s}'")
  counsel--gg-count("" t)
  counsel-git-grep(nil)
  funcall-interactively(counsel-git-grep nil)
  call-interactively(counsel-git-grep nil nil)
  command-execute(counsel-git-grep)

Setting counsel-git-grep-skip-counting-lines resolves this, but I had to read the code before I knew it existed.