-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amx support for counsel #1557
Comments
Amx supports using ivy already. |
Yes, but not counsel. Amx-mode can use Ivy by itself, but most if Ivy people are using counsel-M-x, which optionally uses smex to sort properly (calling smex functions internally out of the box). counsel-M-x checks if smex is installed, if so it calls the functions. Switching to avx is something barely simple, just change the prefixes in counsel.el (I tried) and it worked, but I don't feel confident enough in elisp programming to insert the support for both and make a pull request. |
@Ergus
If a change in your config was enough to make it work, it's good enough for a PR. I'd be happy to review the code, give pointers for improvement and merge it. No pressure, of course. |
@Ergus any update on this one? Looks really interesting :) |
Hi abo-abo sorry for the delay, I was too busy the last days. I just added a pull requests with the changes I did (rebasing master and cleaning up). Please, any suggestion/change/critic/comment will be very welcome, it is my first lisp code ever. |
(counsel--M-x-externs): New function. (counsel-M-x): Use it. Conditionally call amx-rank or smex-rank, when available, from the action function. Borrowing heavily from and building on the work and suggestions of Jimmy Aguilar Mena <kratsbinovish@gmail.com> (@Ergus) in abo-abo#1580. Fixes abo-abo#1557
I am wondering that smex is not actively maintained anymore and the new fork/substitution project is supposed to be amx that is very active right now.
Is it there any plan to support amx in a near/medium future? The interface is pretty much the same as I could see, so the implementation should be relatively simple.
Very thanks
The text was updated successfully, but these errors were encountered: