New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compensate ivy height for variable height unicode fonts #161

Closed
kaushalmodi opened this Issue Jun 24, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@kaushalmodi
Contributor

kaushalmodi commented Jun 24, 2015

The default way using which ivy adjusts the minibuffer height works fine for everything except when dealing with unicode fonts.

Some unicode fonts have more character height than the default and thus situations like below arise when using counsel-unicode-char:

  • Even when I am on the last element, it is displayed partially, because some unicode characters are taller than the default.
  • For instance, it can be seen that the Cyrillic Capital Letter Omega is taller than others.
  • So I can never see what that last character looks like or what it is (It's easy to guess that in this particular example though.).

clipboard01

For such cases, can you add a buffer of 1 or 2 lines at the very end?

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jun 24, 2015

Owner

I'm not seeing your problem in my config, since I just have DejaVu Sans Mono for everything. I solved a similar problem in #151 by getting rid of the custom string height that came from faces.

A similar approach probably won't apply here, since you don't want to have a single font in the minibuffer. Adding an extra line is easy, what's hard is to calculate the pixel height of these 9 lines and check if it's more than the standard minibuffer height. I don't know an API for that. In case you do, please share.

Owner

abo-abo commented Jun 24, 2015

I'm not seeing your problem in my config, since I just have DejaVu Sans Mono for everything. I solved a similar problem in #151 by getting rid of the custom string height that came from faces.

A similar approach probably won't apply here, since you don't want to have a single font in the minibuffer. Adding an extra line is easy, what's hard is to calculate the pixel height of these 9 lines and check if it's more than the standard minibuffer height. I don't know an API for that. In case you do, please share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment