Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-set-display-transformer doesn't work for counsel-describe-ivy #1619

Closed
casouri opened this issue Jun 13, 2018 · 6 comments

Comments

@casouri
Copy link

commented Jun 13, 2018

I executed

(ivy-set-display-transformer 'counsel-describe-face (lambda (str) (format "%s modified" str)))

then called counsel-describe-face, but the candidates are not modified. Did I miss anything?

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2018

This is because ivy-read looks up the display transformer based (effectively) only on its :caller argument, which counsel-describe-face fails to specify. I have added the :caller argument for counsel-describe-face in #1620, but the question of whether ivy-read should also consult this-command remains.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2018

the question of whether ivy-read should also consult this-command remains

This question is addressed by #1621.

@casouri

This comment has been minimized.

Copy link
Author

commented Jun 14, 2018

Cool! Thanks. 😄

@casouri casouri closed this Jun 14, 2018

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2018

You could have waited until #1620 and/or #1621 were merged before closing this issue. :)

@casouri

This comment has been minimized.

Copy link
Author

commented Jun 14, 2018

I’m just afraid that I will forgot and leave this open. I really don’t like stacking issues like what they got in spacemacs repo.

But it’s right to remain open until the issue is proven to be fixed. I agree.

@casouri casouri reopened this Jun 14, 2018

basil-conto added a commit to basil-conto/swiper that referenced this issue Jun 14, 2018
basil-conto added a commit to basil-conto/swiper that referenced this issue Jun 14, 2018

@abo-abo abo-abo closed this in ead529e Jun 14, 2018

abo-abo added a commit that referenced this issue Jun 14, 2018
@casouri

This comment has been minimized.

Copy link
Author

commented Jun 15, 2018

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.