Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-org-tag Not Offering All Completions. #1654

Closed
hannahlbarton opened this issue Jul 6, 2018 · 2 comments

Comments

@hannahlbarton
Copy link

commented Jul 6, 2018

Consider the following org file:
#+TAGS: time chemo chromebook dell computer cycling mobile

  • Test Header. :chemo:

** Test 2. :chromebook:

  • Test 3.

If I remove all the tags from the headings counsel-org-tag offers me a list of all the tags defined in #+TAGS.

However, if I type counsel-org-tag on any of the above headings which already have tags, I am only offered chromebook and chemo as possible completions. I can manually type in any of the other tags and pressing Tab doesn't offer any completions from #+TAGS.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2018

Thanks, I can reproduce this from make plain starting with

Org mode version 9.1.9 (release_9.1.9-65-g5e4542 @ /home/blc/.local/share/emacs/26.1.50/lisp/org/)`

and also with

Org mode version 9.1.13 (9.1.13-elpaplus @ /home/blc/.emacs.d/elpa/org-plus-contrib-20180702/)`

It looks like Org 9, which shipped with Emacs 26, introduced a new buffer-local variable org-current-tag-alist which supersedes the role of org-tag-alist and org-tag-persistent-alist during tag completion.

Tracking down this issue was relatively straightforward, and I will shortly open a PR fixing it, but in the future please provide as many details as possible from the outset, particularly your Emacs and Ivy/Swiper/Counsel versions, as well as the version of any relevant packages, such as Org. This will greatly help the project maintainers in debugging and fixing the issue. Thanks.

basil-conto added a commit to basil-conto/swiper that referenced this issue Jul 7, 2018
counsel.el (counsel-org-tag): Fix for Org 9
Org 9, which shipped with Emacs 26, introduced a new buffer-local
variable org-current-tag-alist which incorporates the values of
org-tag-alist and org-tag-persistent-alist.

Fixes abo-abo#1654

@abo-abo abo-abo closed this in #1656 Jul 9, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jul 9, 2018

The fix is merged, thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.