Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty minibuffer with empty collection and ivy-add-newline-after-prompt #1667

Closed
ericdanan opened this issue Jul 16, 2018 · 2 comments

Comments

@ericdanan
Copy link
Contributor

commented Jul 16, 2018

Hello,

With ivy-add-newline-after-prompt set to t, when ivy-read is called with an empty collection (this happens e.g. if org-read-property-value is called for a property for which there is no value in the current buffer), then nothing is shown in the minibuffer (one empty line). As soon as I type a character, the display becomes correct (two lines: one with the prompt and one with the typed character). Not seeing the prompt is quite inconvenient.

This seems to come from the minibuffer resizing, but I don't how to solve the issue. My only workaround for now is to set ivy-fixed-minibuffer-height to t. Perhaps there is a way to make sure the minibuffer always has at least two lines when ivy-use-newline-after-prompt is t?

Thanks

@abo-abo abo-abo closed this in 321f3c6 Jul 16, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jul 16, 2018

Thanks, please test.

abo-abo added a commit that referenced this issue Jul 16, 2018
ivy.el: Move set-window-text-height call
From post-command-hook to minibuffer-setup-hook.

Re #1667
@ericdanan

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.