Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The official recommended counsel-ag key binding is not very good #1738

Closed
yuzumx opened this issue Aug 31, 2018 · 7 comments

Comments

@yuzumx
Copy link

commented Aug 31, 2018

Hello:

See http://oremacs.com/swiper/#global-key-bindings

I think "C-c k" is easy to confuse with "C-x k".

Although I know this can be changed, but would you like to change the recommendation key binding?

Thanks.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Aug 31, 2018

FWIW, I'm more concerned with the wording "The recommended key bindings are". Shouldn't this read more like "Here are some useful commands, along with sample key bindings" or similar?

@yuzumx

This comment has been minimized.

Copy link
Author

commented Aug 31, 2018

@basil-conto
You are right, but some people will only copy and paste this code into their own init.el -- at least I will. So I think there is nothing wrong with the word "recommended".

But I think it is necessary to choose a more reasonable key binding to add to the description.
Although I don't know which key will be more reasonable. But I don't think a key binding that is easily confused with kill-buffer is reasonable.

Sorry for my poor English.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Aug 31, 2018

Given that key sequences consisting of C-c (mode-specific-map) followed by a letter are reserved for users (see (emacs) Key Bindings, I'd say there are plenty of C-c bindings which are "close" to the corresponding C-x binding. IMO there's little, if at all, we can do about this in the general case.

Besides, kill-buffer prompts the user before doing anything, so accidental mistypes have a relatively low chance of breaking much.

@yuzumx

This comment has been minimized.

Copy link
Author

commented Sep 1, 2018

@basil-conto
Indeed... I found that other key bindings are easy to conflict.
For example, M-?. This is the key binding for counsel-ag I am using now. But it conflicts with the key binding of xref.

BTW What I don't understand is why it is k.

@yuzumx

This comment has been minimized.

Copy link
Author

commented Sep 1, 2018

I think M-s a is good.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2018

I think M-sa is good.

That's what I use in my configuration, in order to reuse search-map. :)

@abo-abo abo-abo closed this in f4dc7f9 Sep 6, 2018

abo-abo added a commit that referenced this issue Sep 6, 2018
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2018

Thanks, I changed the wording a little bit.

BTW What I don't understand is why it is k.

C-c j and C-c k are easy to press, since j/k are on the home row of your right hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.