Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy--kill-buffer-action does not preserve index #1787

Closed
iquiw opened this issue Oct 16, 2018 · 3 comments
Closed

ivy--kill-buffer-action does not preserve index #1787

iquiw opened this issue Oct 16, 2018 · 3 comments

Comments

@iquiw
Copy link
Contributor

@iquiw iquiw commented Oct 16, 2018

I am not sure the behavior is intentional.
I hope ivy--kill-buffer-action acts like ivy-switch-buffer-kill that preserve index after kill, but ivy--kill-buffer-action moves index to the last visited buffer (?).

@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Jan 30, 2019

I tried to unify ivy--kill-buffer-action and ivy-switch-buffer-kill as follows.
iquiw@566e77f

As far as I can check, it works as expected.
@abo-abo Do you think it proper change?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 30, 2019

Sounds OK. Please PR, I'll check again.

@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Jan 30, 2019

Thank you! Sent PR.

@abo-abo abo-abo closed this in c2eb4b5 Jan 30, 2019
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
This moves logic in `ivy-switch-buffer-kill' into `ivy--kill-buffer-action'
and calls the latter from the former, so that `ivy--kill-buffer-action'
acts as same as `ivy-switch-buffer-kill'.

Previously, `ivy--kill-buffer-action' does not preserve the index
after kill.

Fixes abo-abo#1910
Fixes abo-abo#1787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants