Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rainbow-delimiters-mode together with ivy-overlay uses face from delimiter #1808

Closed
terlar opened this issue Nov 18, 2018 · 4 comments

Comments

@terlar
Copy link

commented Nov 18, 2018

When having rainbow-delimiters-mode enabled in an Emacs-Lisp file for example and having the cursor on a symbol/word that is directly after the parenthesis it will inherit the face from the parenthesis.

ivy-first-word

ivy-second-word

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Nov 18, 2018

Could this be the same as #1016, #1488, and #1547?

@terlar

This comment has been minimized.

Copy link
Author

commented Nov 18, 2018

Yeah, I think so, thanks for the info. I was searching for rainbow-delimiters-mode specifically so didn't find those issues, but definitely sound like the same issue. I will close this as a duplicate.

@terlar terlar closed this Nov 18, 2018

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Nov 27, 2018

Does commit 7434a79 solve the issue for you?

basil-conto added a commit to basil-conto/swiper that referenced this issue Nov 27, 2018
ivy-overlay.el: Simplify overlay face overriding
This is a refactor of the following commit:

ivy-overlay.el (ivy-overlay-show-after): Don't inherit existing face
  2018-11-27 12:31:32 +0100 7434a79

(ivy--overlay-font-lock-hack): Remove.
(ivy-overlay-show-after): Specify default face of ivy-overlay-at to
avoid clashing with other overlays.

Re: abo-abo#1016, abo-abo#1488, abo-abo#1520, abo-abo#1547, abo-abo#1808
@terlar

This comment has been minimized.

Copy link
Author

commented Nov 27, 2018

@basil-conto This indeed seems to have fixed it. Thank you very much! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.