counsel-rg ivy-occur is broken on Windows

[mookid]

At least on windows, jumping to a match does not work anymore on master.

To reproduce:
in the swiper repo, searching for cl-delete yields the following ivy-occur buffer:

-*- mode:grep; default-directory: "~/src/swiper/" -*-


5 candidates:
    .\counsel.el:1610:              (or (cl-delete default-directory (counsel-git-worktree-list)
    .\counsel.el:3533:    (set sym (cl-delete-duplicates
    .\counsel.el:3534:              (cl-delete-if-not counsel-yank-pop-filter (symbol-value sym))
    .\counsel.el:3565:    (set sym (cl-delete s (symbol-value sym)
    .\ivy.el:280:                   (cl-delete-duplicates

As a consequence, pressing RET fails to jump to the match.
A minimal patch to work around the issue is the following:

--- a/ivy.el
+++ b/ivy.el
@@ -4119,7 +4119,7 @@ When `ivy-calling' isn't nil, call `ivy-occur-press'."
        highlight
        help-echo "mouse-1: call ivy-action")
      str)
-    (insert (if (string-prefix-p "./" str) "" "    ")
+    (insert (if (or (string-prefix-p "./" str) (string-prefix-p ".\\" str)) "" "     ")
             str ?\n))
   (goto-char (point-min))
   (forward-line 4)

[basil-conto]

(insert (if (or (string-prefix-p "./" str) (string-prefix-p ".\\" str)) "" " ")

AKA

(if (string-match-p "\\`\\.[/\\]" str) "" "     ")

But this is looking increasingly brittle and hard-coded (platform-specific file name manipulation can and should be avoided!). Isn't there a more declarative way of achieving a similar effect?

[iquiw]

Does --path-separator option of ripgrep help?

        --path-separator <SEPARATOR>
            Set the path separator to use when printing file paths. This defaults to your
            platform's path separator, which is / on Unix and \ on Windows. This flag is
            intended for overriding the default when the environment demands it (e.g.,
            cygwin). A path separator is limited to a single byte.

[mookid]

But this is looking increasingly brittle and hard-coded (platform-specific file name manipulation can and should be avoided!). Isn't there a more declarative way of achieving a similar effect?

I am not advocating for the inclusion of that patch, just saying that this fixes my issue.
For a proper fix, let somebody write a proper PR.

[mookid]

Does --path-separator option of ripgrep help?

I am not sure that ripgrep is the only backend affected by this.

[abo-abo]

Thanks, I'm fine with applying the suggested patch.

The whole if statement is a hack anyway. If there's time for a refactor, ivy--occur-insert-lines should know if it's called by a grep-like caller or not and insert appropriately " " or "". Right now, we extract this info from the strings to be inserted.

[iquiw]

swiper/ivy.el

Line 4126 in 7b6765b

(insert (if (string-prefix-p "\\`.[/\\]" str) "" " ")

Shouldn't it be string-match-p as in #1817 (comment) ?

[abo-abo]

@iquiw Thanks, fixed.