Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: independent faces for ivy/swiper/counsel #1839

Closed
diamond-lizard opened this issue Dec 5, 2018 · 3 comments
Closed

Feature request: independent faces for ivy/swiper/counsel #1839

diamond-lizard opened this issue Dec 5, 2018 · 3 comments

Comments

@diamond-lizard
Copy link

@diamond-lizard diamond-lizard commented Dec 5, 2018

I'd like to request that ivy, counsel, and swiper always use their own faces rather than pre-existing faces, so that customizing how they look is possible without affecting the faces of other modes.

For instance, currently both ivy and swiper have the compilation-info face hardcoded in to them, and in addition swiper has the compilation-line-number face hardcoded in to it. This makes it impossible to customize the way ivy and swiper look independently of how compilation-mode looks.

It would be great if ivy, counsel, and swiper used their own faces for all of these and any other faces they may need.

basil-conto added a commit to basil-conto/swiper that referenced this issue Dec 5, 2018
ivy.el (ivy-grep-info, ivy-grep-line-number): New faces inheriting
compilation-info and compilation-line-number, respectively.
(ivy--occur-insert-lines):
swiper.el (swiper-occur):
counsel.el (counsel-git-grep-transformer)
(counsel-imenu-get-candidates-from): Use them.

Re: abo-abo#1839
@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Dec 5, 2018

It would be great if ivy, counsel, and swiper used their own faces for all of these

See #1840.

and any other faces they may need.

Please report any other faces you spot. Thanks.

abo-abo added a commit that referenced this issue Dec 6, 2018
ivy.el (ivy-grep-info, ivy-grep-line-number): New faces inheriting
compilation-info and compilation-line-number, respectively.
(ivy--occur-insert-lines):
swiper.el (swiper-occur):
counsel.el (counsel-git-grep-transformer)
(counsel-imenu-get-candidates-from): Use them.

Re: #1839
Fixes #1840
@mookid
Copy link
Contributor

@mookid mookid commented Dec 12, 2018

@diamond-lizard do you think that this issue can be closed?

@diamond-lizard
Copy link
Author

@diamond-lizard diamond-lizard commented Dec 13, 2018

Yes. Absolutely. Thanks for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants